-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Feature][Flink] Add flink version 1.20.1 support #9576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Good pr |
...-starter/src/main/java/org/apache/seatunnel/core/starter/flink/execution/FlinkExecution.java
Outdated
Show resolved
Hide resolved
...ation-flink-20/src/main/java/org/apache/seatunnel/translation/flink/source/SplitWrapper.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need new flink 1.20.1 test container to verify it. https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/container/flink
...-starter/src/main/java/org/apache/seatunnel/core/starter/flink/execution/FlinkExecution.java
Outdated
Show resolved
Hide resolved
...-20/src/main/java/org/apache/seatunnel/translation/flink/metric/FlinkAccumulatorCounter.java
Outdated
Show resolved
Hide resolved
...-20/src/main/java/org/apache/seatunnel/translation/flink/metric/FlinkAccumulatorCounter.java
Outdated
Show resolved
Hide resolved
...-20/src/main/java/org/apache/seatunnel/translation/flink/metric/FlinkAccumulatorCounter.java
Outdated
Show resolved
Hide resolved
...flink-20/src/main/java/org/apache/seatunnel/translation/flink/metric/FlinkMetricContext.java
Outdated
Show resolved
Hide resolved
|
waiting test case passes. |
|
@yzeng1618 CI failed. Please check |
Currently, it seems that there is an issue with the CI (Continuous Integration) process of the dev (development) environment itself. |
@Hisoka-X @zhangshenghang It seems there's a problem with the mirror image. Do you have any updated information?
|
It should be working normally now, and other users haven't reported this issue. |
|
Please merge dev. it fix the timeout issue. |
# Conflicts: # .github/workflows/backend.yml # seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/execution/SinkExecuteProcessor.java
Have merged |
|
Please pull the latest changes and try again. |
|
@Hisoka-X @TyrantLucifer @Carl-Zhou-CN @zhangshenghang After adapting the new code and fixing the CI (Continuous Integration) process, the modifications have now been completed. Could you please help review this |


#9513
Purpose of this pull request
This pull request fixes the Flink 1.20 compatibility issue in the SeaTunnel Flink translation layer. The current implementation uses reflection to access internal StreamingRuntimeContext from SourceReaderContext, which is fragile and may break with Flink version updates.
Does this PR introduce any user-facing change?
No. This is an internal implementation fix that maintains the same public API behavior. Users will continue to use the same SeaTunnel connector APIs without any changes. The metrics functionality remains identical from the user perspective.
How was this patch tested?
Manual Testing:
Built SeaTunnel with Flink 1.20 dependencies
Ran sample connector jobs to verify metrics collection
Confirmed no reflection-related errors in logs
Validated metrics appear correctly in Flink Web UI
Check list
New License Guide