Skip to content

Conversation

@yzeng1618
Copy link
Contributor

@yzeng1618 yzeng1618 commented Jul 15, 2025

#9513

Purpose of this pull request

This pull request fixes the Flink 1.20 compatibility issue in the SeaTunnel Flink translation layer. The current implementation uses reflection to access internal StreamingRuntimeContext from SourceReaderContext, which is fragile and may break with Flink version updates.

Does this PR introduce any user-facing change?

No. This is an internal implementation fix that maintains the same public API behavior. Users will continue to use the same SeaTunnel connector APIs without any changes. The metrics functionality remains identical from the user perspective.

How was this patch tested?

Manual Testing:
Built SeaTunnel with Flink 1.20 dependencies
Ran sample connector jobs to verify metrics collection
Confirmed no reflection-related errors in logs
Validated metrics appear correctly in Flink Web UI

Check list

@github-actions github-actions bot added core SeaTunnel core module flink api labels Jul 15, 2025
@Hisoka-X
Copy link
Member

cc @TyrantLucifer

@Hisoka-X Hisoka-X changed the title [improve][start] Seatunnel version support 1.20.1 [Feature][Flink] Add flink version 1.20.1 support Jul 15, 2025
@TyrantLucifer
Copy link
Member

Good pr

@nielifeng nielifeng requested a review from Copilot July 17, 2025 09:46

This comment was marked as outdated.

@yzeng1618 yzeng1618 requested a review from TyrantLucifer July 19, 2025 10:57
@yzeng1618 yzeng1618 requested a review from Carl-Zhou-CN July 27, 2025 09:50
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the e2e label Aug 3, 2025
@yzeng1618 yzeng1618 requested a review from Hisoka-X September 29, 2025 10:14
@Hisoka-X
Copy link
Member

Hisoka-X commented Oct 1, 2025

waiting test case passes.

@Carl-Zhou-CN
Copy link
Member

Carl-Zhou-CN commented Oct 13, 2025

@yzeng1618 CI failed. Please check

@yzeng1618
Copy link
Contributor Author

waiting test case passes.

@yzeng1618 CI failed. Please check

Currently, it seems that there is an issue with the CI (Continuous Integration) process of the dev (development) environment itself.

@Carl-Zhou-CN
Copy link
Member

image @Hisoka-X @zhangshenghang It seems there's a problem with the mirror image. Do you have any updated information?

@zhangshenghang
Copy link
Member

image @Hisoka-X @zhangshenghang It seems there's a problem with the mirror image. Do you have any updated information?

It should be working normally now, and other users haven't reported this issue.

@zhangshenghang
Copy link
Member

Please merge dev. it fix the timeout issue.

# Conflicts:
#	.github/workflows/backend.yml
#	seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/execution/SinkExecuteProcessor.java
@yzeng1618
Copy link
Contributor Author

Please merge dev. it fix the timeout issue.

Have merged

@dybyte
Copy link
Contributor

dybyte commented Oct 26, 2025

Please pull the latest changes and try again.

@yzeng1618
Copy link
Contributor Author

@Hisoka-X @TyrantLucifer @Carl-Zhou-CN @zhangshenghang After adapting the new code and fixing the CI (Continuous Integration) process, the modifications have now been completed. Could you please help review this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants